Feat/Configure Storage Service Variables #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added LOCAL_STORAGE_PATH to .env.example for local development fallback - Updated backend and worker workflows to include STORAGE_SERVICE_URI, STORAGE_SERVICE_ACCOUNT_KEY, and LOCAL_STORAGE_PATH - Modified service-secrets-config.sh.example to export new storage-related variables for development, staging, and production - Enhanced service-secrets-create.sh to document new environment variables for storage services This improves local development setup and ensures consistent access to storage services across environments.
update local feature branch with the remote main
…configuration - Added STORAGE_SERVICE_URI, STORAGE_SERVICE_ACCOUNT_KEY, and LOCAL_STORAGE_PATH to backend-test.yml and worker.yml - Updated STORAGE_SERVICE_ACCOUNT_KEY formatting in backend.yml for consistency These changes improve the configuration for storage services across workflows, ensuring better integration and access to necessary environment variables.
- Changed STORAGE_SERVICE_ACCOUNT_KEY to decode the base64 encoded value in both backend-test.yml and backend.yml - Ensures consistent handling of sensitive storage service credentials across workflows This update improves security and standardizes the configuration for accessing storage services.
…kflows - Updated STORAGE_SERVICE_ACCOUNT_KEY in backend-test.yml, backend.yml, and worker.yml to remove base64 decoding for consistency. - Added STORAGE_PROJECT_ID, STORAGE_SERVICE_URI, STORAGE_SERVICE_ACCOUNT_KEY, and LOCAL_STORAGE_PATH to service-secrets-create.sh for improved environment variable management. These changes enhance the security and uniformity of storage service configurations across the project.
update feature branch with remote main.
- Updated the method of setting environment variables in backend.yml to use a more concise format. - This change enhances readability and maintainability of the workflow configuration. - Ensures consistent handling of environment variables across different deployment scenarios.
… service environment variables - Added STORAGE_PROJECT_ID, STORAGE_SERVICE_URI, STORAGE_SERVICE_ACCOUNT_KEY, and LOCAL_STORAGE_PATH to the usage output. - Enhances clarity and usability for configuring storage service settings.
… workflows" This reverts commit 39721ab.
…g for STORAGE_SERVICE_ACCOUNT_KEY - Added notes in service-secrets-config.sh.example and service-secrets-create.sh to specify that STORAGE_SERVICE_ACCOUNT_KEY should be Base64 encoded JSON. - Enhances clarity and consistency in handling service account keys across environments.
update local feature branch with the remote main branch.
…vice - Modified .env.example to clarify the format for STORAGE_SERVICE_ACCOUNT_KEY. - Updated backend-test.yml to include STORAGE_PROJECT_ID and corrected STORAGE_SERVICE_ACCOUNT_KEY formatting. - Enhanced service-secrets-config.sh.example with additional storage service variables and notes on Base64 encoding for STORAGE_SERVICE_ACCOUNT_KEY.
harry-rhesis
requested changes
Oct 10, 2025
There was a problem hiding this comment.
Hi @asadaaron, thank you for this PR; would you please remove STORAGE_PROJECT_ID as @EmanueleDeRossi1's instructions? Thanks!
- Removed STORAGE_PROJECT_ID from backend-test.yml, backend.yml, worker.yml, service-secrets-config.sh.example, and service-secrets-create.sh to streamline environment variable management. - Enhances clarity and consistency in the configuration of storage service settings.
update local feature branch with the remote branch.
Hi @harry-rhesis |
…ration - Introduced STORAGE_SERVICE_URI, STORAGE_SERVICE_ACCOUNT_KEY, and LOCAL_STORAGE_PATH as environment variables in deployment.yaml. - These additions enhance the configuration for the storage service, improving flexibility and management of service settings.
harry-rhesis
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes from the
feat/configure-storage-service-variablesbranch.📝 Summary
📁 Files Changed ( 5 files)
📋 Commit Details
✅ Checklist
🧪 Testing
📸 Screenshots (if applicable)
🔗 Related Issues